handle non-200 status codes from root __layout.svelte#4665
Merged
Rich-Harris merged 11 commits intomasterfrom Jul 14, 2022
Merged
handle non-200 status codes from root __layout.svelte#4665Rich-Harris merged 11 commits intomasterfrom
__layout.svelte#4665Rich-Harris merged 11 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: 6b6c485 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
I haven't fully been following what's happening in that issue - but from your description in this PR, it sounds at least somewhat adjacent to #3068 - although the symptoms are different |
5 tasks
Rich-Harris
commented
Jul 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4659. Just a failing test for now. Looks like the 'bail out and render a generic 500 if an error occurs while rendering an error page' thing only applies to errors that are thrown;
return { status: 404 }doesn't do the trick.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0