Revert change to render fallback when prerendering is disabled#4604
Merged
Rich-Harris merged 6 commits intosveltejs:masterfrom Apr 13, 2022
Merged
Revert change to render fallback when prerendering is disabled#4604Rich-Harris merged 6 commits intosveltejs:masterfrom
Rich-Harris merged 6 commits intosveltejs:masterfrom
Conversation
🦋 Changeset detectedLatest commit: d3f059f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Apr 13, 2022
Rich-Harris
reviewed
Apr 13, 2022
Rich-Harris
approved these changes
Apr 13, 2022
Member
|
thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4492.
Loading
hooks.jsand/or executing thehandlehook during the build process causes problems for some people, and so rendering the fallback page event when prerendering is disabled presents those people with build failures that can not be worked around. This PR reverts #4443, which enabled that behavior after the prerender process was moved into the build step.For those like me who need a fallback page but are saddled with code that causes the build process to fail because Node.js throws a tantrum when you even try to
importa page component, a configuration workaround is presented in the README foradapter-static. (An example is dependencies that are ESM compatible, but not in the exact one way that Node requires them to be.)Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpx changesetand following the prompts. All changesets should bepatchuntil SvelteKit 1.0