🦋 Changeset detected

Latest commit: 911b5b6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Halleluja! \o/ :)

I think we need to tread very carefully here, and consider what this looks like in non-Node-like environments, and how it affects other things. For example https://kit.svelte.dev/faq#how-do-i-use-x-with-sveltekit-how-do-i-use-middleware makes me nervous (the fact that you need to specify middleware both in your custom server and in your config); to me this feels like a symptom of a design that isn't fully baked.

At the very least, platformReq probably isn't the right name given that Lambdas and Cloudflare Workers etc refer to 'events' rather than 'requests'.

For example https://kit.svelte.dev/faq#how-do-i-use-x-with-sveltekit-how-do-i-use-middleware makes me nervous (the fact that you need to specify middleware both in your custom server and in your config); to me this feels like a symptom of a design that isn't fully baked.

Yeah, I agree with this. In the meantime I figured I'd at least document what's possible at the moment to unblock folks who need the functionality even if it's not ideal. Though that seems like somewhat of a separate issue?

At the very least, platformReq probably isn't the right name given that Lambdas and Cloudflare Workers etc refer to 'events' rather than 'requests'.

Any other suggestions? Even if those platforms use the word events to refer to requests, they're still requests. I think the folks using those platforms are unlikely to be confused and they're probably pretty unlikely to need to use it anyway

Talked about this in today's maintainer's meeting. Rich suggested we provide a way to put stuff from the original request into locals instead