Skip to content

adapter-vercel should respect esbuild configs#1732

Closed
thmsmlr wants to merge 1 commit into
sveltejs:masterfrom
thmsmlr:esbuild-vercel
Closed

adapter-vercel should respect esbuild configs#1732
thmsmlr wants to merge 1 commit into
sveltejs:masterfrom
thmsmlr:esbuild-vercel

Conversation

@thmsmlr

@thmsmlr thmsmlr commented Jun 21, 2021

Copy link
Copy Markdown

This patch attempts to solve #1706
We pass through the esbuild configurations in svelte.config.cjs into the
esbuild step of the vercel adapter.

This is primarily to solve the case where we have external packages that
are skipped by esbuild in adapater-node, but not adpater-vercel.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@thmsmlr
adapter-vercel should respect esbuild configs
c739b16 
This patch attempts to solve sveltejs#1706
We pass through the esbuild configurations in svelte.config.cjs into the
esbuild step of the vercel adapter.

This is primarily to solve the case where we have external packages that
are skipped by esbuild in adapater-node, but not adpater-vercel.
@changeset-bot

changeset-bot Bot commented Jun 21, 2021

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c739b16

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann added the pkg:adapter-vercel Pertaining to the Vercel adapter label Jun 21, 2021
@benmccann

benmccann commented Jun 21, 2021

Copy link
Copy Markdown
Member

If we're going to make this change, I assume we should also make it in the other adapters that use esbuild as well?

@benmccann

benmccann commented Jun 21, 2021

Copy link
Copy Markdown
Member

There's a related PR that's attempting to pass esbuild options into adapter-node via a new option in #1692

@benmccann benmccann mentioned this pull request Jun 21, 2021
Closed
5 tasks
@Nick-Mazuk Nick-Mazuk mentioned this pull request Jun 30, 2021
Closed
benmccann
benmccann reviewed Jul 3, 2021
View reviewed changes
Comment thread packages/adapter-vercel/index.js
bundle: true,
platform: 'node'
platform: 'node',
...config?.kit?.vite()?.esbuild

@benmccann benmccann Jul 3, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that reusing vite's esbuild config here is not the best way. People way want to configure the two separately. E.g. see #1692 (comment)

@GrygrFlzr GrygrFlzr mentioned this pull request Jul 15, 2021
Merged
2 tasks
@umwwwelt

umwwwelt commented Jul 16, 2021

Copy link
Copy Markdown

@Nick-Mazuk any news ?

@thmsmlr thmsmlr deleted the esbuild-vercel branch July 19, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann left review comments

Assignees

No one assigned

Labels

awaiting submitter pkg:adapter-vercel Pertaining to the Vercel adapter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thmsmlr @benmccann @umwwwelt