fix: reduce pending count even if form with enhance was never submitted#15602
Closed
paoloricciuti wants to merge 1 commit intomainfrom
Closed
fix: reduce pending count even if form with enhance was never submitted#15602paoloricciuti wants to merge 1 commit intomainfrom
paoloricciuti wants to merge 1 commit intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 3dfc15d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
Member
Author
|
Closing this in favor of #15520 which is a better fix (and was earlier) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15519
Currently, if you have an
enhancefunction, and you conditionally invokesubmitthependingvalue never goes downREPL
if you left the checkbox unchecked and submit multiple times, the value of pending will go higher and higher.
This fixes that by checking if the submit function was invoked and decreasing pending in a finally block