fix(adapter-netlify)!: write output conforming to Netlify Frameworks API#15294
Conversation
The Netlify adapter now generates "v2" Netlify Functions, which uses modern standards (ESM, Request, Response) instead of the legacy "Lambda-compatible" or "v1" format. Under the hood, this greatly simplifies the adapter code and improves maintainability. See more details in this guide: https://developers.netlify.com/guides/migrating-to-the-modern-netlify-functions/. Some key changes: - The use of Request/Resonse eliminated the need for special header parsing, special multi-value handling header, base64 encoding of binary responses, and more. - Configuration of function routing directly in code eliminated the need for `_redirects` file generation. - As a bonus, this removes the limitation that users cannot specify redirects in `netlify.toml`. BREAKING CHANGES: - `platform.context` type changed to https://docs.netlify.com/build/functions/api/#netlify-specific-context-object
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
This reverts commit 0d14399.
🦋 Changeset detectedLatest commit: 74f639b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
…serhalp/sveltejs-kit into refactor/netlify-frameworks-api
| # build output because the Netlify dev plugin doesn't currently detect it | ||
| [functions] | ||
| directory = ".netlify/functions-internal" | ||
| directory = ".netlify/v1/functions" |
There was a problem hiding this comment.
@serhalp is there any way we could get the Netlify dev plugin to work with the Netlify framework API so we no longer need this hack? Currently, I don't think it picks up these directories or config.json
There was a problem hiding this comment.
Yes, I'm working on it actually! I actually realized the issue is that @netlify/dev isn't quite designed yet for a preview/serve context. It doesn't scan output directories, only source.
There was a problem hiding this comment.
Should we go ahead with this test workaround and leave a todo to remove this once @netlify/dev supports it?
Added a TODO comment regarding @netlify/dev compatibility with the Netlify frameworks API.
(Stacked on top of #15203)closes #15169
The current implementation of the Netlify adapter writes output to paths and config files that are under-documented and in some cases entirely undocumented.
18 months ago, Netlify addressed this by releasing the stable, documented Netlify Frameworks API](https://docs.netlify.com/build/frameworks/frameworks-api/).
This PR migrates the adapter to write output that conforms to this spec.
POTENTIALLY BREAKING CHANGE: Deploying and previewing with Netlify CLI now requires v17.31.0 or later. Run
npm i -g netlify-cli@latestto upgrade.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits