@sveltejs/package: Assume no svelte 3 if can't read version with semver (pnpm calalog)#13553
@sveltejs/package: Assume no svelte 3 if can't read version with semver (pnpm calalog)#13553jycouet wants to merge 5 commits intosveltejs:mainfrom
Conversation
|
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
|
I don't really know if this is safe. What happens if it is a Svelte 3 app with a |
|
You are right, this is not "safe". I'll look at this later :) |
|
Done with #13850 |
|
Oh no, I didn't realize you made a PR many weeks ago for this already - sorry |
I'm using
pnpmand thecatalogfeature.It's nice in monorepos to manage deps & version in one place. (+ you can name & group deps)
In
package.json:{ "peerDependencies": { "svelte": "catalog:svelte-dep" } }An in
pnpm-workspace.yamlBUT, it's not
semverstandard. :( (Maybe one day?)That's why I would suggest this fix ?
Feel free to le me know what do you think
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits