fix: use window.fetch for server load fetch requests#13315
Merged
dummdidumm merged 8 commits intosveltejs:mainfrom Jan 15, 2025
Merged
fix: use window.fetch for server load fetch requests#13315dummdidumm merged 8 commits intosveltejs:mainfrom
window.fetch for server load fetch requests#13315dummdidumm merged 8 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 813f05f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
preview: https://svelte-dev-git-preview-kit-13315-svelte.vercel.app/ this is an automated message |
ad6c8ef to
a11834e
Compare
window.fetch for server load fetch requests
Merged
Contributor
Author
|
Thanks for the quick turn around! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a follow up on #10009 which ensured that the
fetchfunction from theloadevent would callwindow.fetchso that libraries (like Sentry but there are many others) can patch it. Unfortunately, I missed back then that there's another kind offetchrequest made by SvelteKit: Whenever a user navigates to a route that contains a server-load function, a request is made to fetch the server-load data.This PR ensures that this server-load data request is also patchable by basically using the same mechanism introduced in #10009. I also added a test that would prior to this change fail.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits