⚠️ No Changeset found

Latest commit: 66e6b2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

preview: https://svelte-dev-git-preview-kit-13125-svelte.vercel.app/

this is an automated message

I'd love an api where serialize and deserialize implementations for a custom type are in the same file.

They have a strict relation to one another and changing one without the other can lead to bugs. It would also simplify implementing tests that ensure serialize(deserialize(x)) equals x and deserialize(serialize(y)) equals y

Users can possibly do that in userland by importing them from such a file, but just lik param matchers i think we could provide that from a known location.

I'd love an api where serialize and deserialize implementations for a custom type are in the same file.

They have a strict relation to one another and changing one without the other can lead to bugs. It would also simplify implementing tests that ensure serialize(deserialize(x)) equals x and deserialize(serialize(y)) equals y

Users can possibly do that in userland by importing them from such a file, but just lik param matchers i think we could provide that from a known location.

So I tried to do something like that, but I gave up. I couldn't figure out how how we could safely take the function on the server and use it on the client, given the function references imports, and generate client code with the same logic without leaking server stuff. This is my first Kit PR, so maybe I just need someone to help me understand how that sort of thing can be done.

its a pair of pure functions tied together by a name, so shouldn't it work in a similar way as matchers?
maybe 3 functions if you want to add a test function too

//src/serializers/foo.js
export const is(foo: any): boolean;
export const serialize(foo: Foo): string;
export const deserialize(str: string): Foo;

due to treeshaking only one of serialize and deserialize should make it to the output of client or server.

its a pair of pure functions tied together by a name, so shouldn't it work in a similar way as matchers? maybe 3 functions if you want to add a test function too

//src/serializers/foo.js
export const is(foo: any): boolean;
export const serialize(foo: Foo): string;
export const deserialize(str: string): Foo;

due to treeshaking only one of serialize and deserialize should make it to the output of client or server.

The body of the functions will require importing the class though. So when it runs on the client, the import will be missing?

I'd love an api where serialize and deserialize implementations for a custom type are in the same file.

It's not done like that because currently we're not using the serialize function on the client / the deserialize function on the server.

@dummdidumm Thanks for the feedback. Fixed!

Opened an alternative PR that puts the encoding/decoding logic in a single hook: #13149

Closing in favor of #13149