Skip to content

SPA mode#1181

Merged
Rich-Harris merged 18 commits intomasterfrom
gh-754
Apr 23, 2021
Merged

SPA mode#1181
Rich-Harris merged 18 commits intomasterfrom
gh-754

Conversation

@Rich-Harris
Copy link
Copy Markdown
Member

@Rich-Harris Rich-Harris commented Apr 23, 2021

Closes #754.

With this, we can specify a fallback page when using adapter-static. This page contains no content, but will load the SvelteKit app and invoke the router, making it suitable as a 200.html with e.g. Surge, or an index.html with sirv with opts.single.

If a fallback is specified, adapter-static won't forcibly prerender every page, just the ones with prerender = true.

I added a test suite to adapter-static.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

benmccann
benmccann reviewed Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to make lots of people super happy! Big announcement for the Summit 😄

Do you think it's worth filing an issue about force disabling SSR as well? #754 (comment)

packages/adapter-static/index.js Outdated

return adapter;
};
import commonjs from './index.cjs';
Copy link
Copy Markdown
Member

@benmccann benmccann Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be worth adding a comment here explaining why we need to use CommonJS with an ESM wrapper

Copy link
Copy Markdown
Member Author

@Rich-Harris Rich-Harris Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised there's actually no benefit to this file — removed

SOVLOOKUP
SOVLOOKUP reviewed Apr 23, 2021
View reviewed changes
packages/adapter-static/package.json Outdated
"format": "prettier --write . --config ../../.prettierrc --ignore-path .gitignore",
"check-format": "prettier --check . --config ../../.prettierrc --ignore-path .gitignore"
"check-format": "prettier --check . --config ../../.prettierrc --ignore-path .gitignore",
"test": "rm -rf test/apps/*/build && uvu test test.js"
Copy link
Copy Markdown

@SOVLOOKUP SOVLOOKUP Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1183 this change can make test work in windows

@Rich-Harris
Copy link
Copy Markdown
Member Author

Rich-Harris commented Apr 23, 2021

Do you think it's worth filing an issue about force disabling SSR as well?

I'd rather wait for that to come up organically — I would rather we investigate alternatives (like static analysis) before providing an 'eject' button that is likely to be misused. People will just forcibly disable SSR as soon as they run into the smallest SSR problem if the option is available to them, rather than working through the problem and preserving SSR-ability where possible. That would be bad stewardship on our part.

Conduitry
Conduitry reviewed Apr 23, 2021
View reviewed changes
@Rich-Harris Rich-Harris merged commit 4131467 into master Apr 23, 2021
@Rich-Harris Rich-Harris deleted the gh-754 branch April 23, 2021 12:11
benmccann
benmccann reviewed Apr 23, 2021
View reviewed changes
packages/adapter-static/index.cjs
@@ -1,4 +1,4 @@
module.exports = function ({ pages = 'build', assets = 'build' } = {}) {
module.exports = function ({ pages = 'build', assets = pages, fallback = null } = {}) {
Copy link
Copy Markdown
Member

@benmccann benmccann Apr 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this file need to be renamed to .cjs?

Copy link
Copy Markdown
Contributor

@ivoreis ivoreis Apr 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it can be required by the config file https://github.com/sveltejs/kit/pull/1181/files#diff-ffa86c05d95319420b7940aecaf8b3f028dad6acf5e1ed7005b0955b01325801 / https://github.com/sveltejs/kit/pull/1181/files#diff-46bfbc5b8cd21784f755621d040007b8c28047b8d1c13dbb304555fbcec53d00

@plunkettscott plunkettscott mentioned this pull request May 31, 2021
Closed
@btakita
Copy link
Copy Markdown

btakita commented Jul 16, 2021 •
edited
Loading

I have a requirement package an app using the file:// protocol, meaning there is no web server. I would love svelte kit to have SSR-less SPA capability. I could use Routify & Sapper but would rather use Svelte Kit to have both a PWA & a file:// based SPA.

@benmccann
Copy link
Copy Markdown
Member

benmccann commented Jul 19, 2021

@btakita the issue to track that is #907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benmccann benmccann benmccann left review comments

@Conduitry Conduitry Conduitry left review comments

+2 more reviewers

@ivoreis ivoreis ivoreis left review comments

@SOVLOOKUP SOVLOOKUP SOVLOOKUP left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

True SPA mode

6 participants

@Rich-Harris @btakita @benmccann @ivoreis @Conduitry @SOVLOOKUP