Skip to content

fix: adjust missing inner content warning#11394

Merged
benmccann merged 3 commits intomainfrom
i-11127-v2
Dec 19, 2023
Merged

fix: adjust missing inner content warning#11394
benmccann merged 3 commits intomainfrom
i-11127-v2

Conversation

@ignatiusmb
Copy link
Member

Alright, v2 of #11380

Svelte 5 can still use <slot> and +layout can now accept "named slots" with snippets. I think we can safely assume some content will be rendered, as long as a {@render tag exists in the markup, without having to check which snippet(s) also exists in the script.

Closes #11127

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: f805394

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Svelte 5: prompt "<slot /> missing" when using children snippet instead of <slot /> in +layout.svelte

3 participants