fix(adapter-node): merge sourcemaps#10069
Merged
dummdidumm merged 7 commits intoadapter-node-externalizefrom Jun 26, 2023
Merged
fix(adapter-node): merge sourcemaps#10069dummdidumm merged 7 commits intoadapter-node-externalizefrom
dummdidumm merged 7 commits intoadapter-node-externalizefrom
Conversation
🦋 Changeset detectedLatest commit: 3dc5acd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
benmccann
reviewed
Jun 6, 2023
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
dummdidumm
reviewed
Jun 23, 2023
| if (!should_process_sourcemaps(id)) return; | ||
| if (!existsSync(`${id}.map`)) return; | ||
| const [code, map] = await Promise.all([ | ||
| readFile(id, 'utf-8'), |
Member
There was a problem hiding this comment.
why is this using readFile when other places use readFileSync? Is this really an observable performance difference?
Member
There was a problem hiding this comment.
this one is reading two files in parallel, so I think readFile would be more performant here, so if we want to standardize I think I'd rather use readFile than readFileSync
dummdidumm
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This targets the branch for #10041.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.