🦋 Changeset detected

Latest commit: 0c332f1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

• is the README updated?

No, not yet, will add docs.

• is this potentially breaking in any way? Try around with a local svelte install, as we had unexpected issues with this before

i don't believe so, as unless you pass custom handlers, it defaults to js + ts, which is the existing behavior, and all the tests pass, but i'll try with a svelte install

• If someone for some reason that i don't understand right would like to change the behavior of printing Literal, but still use all the other parts from esrap. is this possible? I think it should be, but untested as well

yes! you just need to do something like

print(..., {
    handlers: {
        ...ecmascript,
       Literal(node, state) {
           state.commands.push('this is my really cool literal that overrides the default one!');
       }
    }
})

i can't test on svelte right now, my pnpm is kinda cooked, if someone else would test it, that would be greatly appreciated, if not, i'll still test, it just might be a while

npm i https://pkg.pr.new/sveltejs/esrap@68

commit: 0c332f1

Thank you! This is a wonderful start. For this to be truly pluggable, visitors can't rely on internals like indent and handle, those things need to be part of the context. I'll work on this locally.

Tested with svelte, no breakage

This could probably use some more JSX tests (for now I've just marked JSX support as experimental), but other than that I think it's ready for review.

The one thing I can't figure out is the type errors I'm seeing on sveltejs/svelte#16188