[WIP] Update model loading enhancements and .gitignore#54
Merged
suzukimain merged 2 commits intoupdate-v9from Dec 16, 2025
Merged
[WIP] Update model loading enhancements and .gitignore#54suzukimain merged 2 commits intoupdate-v9from
suzukimain merged 2 commits intoupdate-v9from
Conversation
Co-authored-by: suzukimain <131413573+suzukimain@users.noreply.github.com>
Copilot stopped work on behalf of
suzukimain due to an error
December 16, 2025 10:41
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a critical bug where nested try-except blocks in the pipeline loading logic caused failed_count to be incremented twice for the same failure. The refactoring separates search and pipeline loading into sequential try-except blocks, ensuring accurate error tracking.
Key Changes:
- Restructured nested try-except blocks into sequential blocks to prevent double-counting of failures
- Search failures are now caught and handled independently from pipeline loading failures
- Each failure type now increments
failed_countexactly once
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on addressing nested try-except double-counting issue
Security Summary
No vulnerabilities were discovered in this change. CodeQL analysis returned 0 alerts.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.