Skip to content

Restore logger.warning for checkpoint_path in HuggingFace loader#52

Merged
suzukimain merged 2 commits intoupdate-v9from
copilot/sub-pr-49-another-one
Dec 16, 2025
Merged

Restore logger.warning for checkpoint_path in HuggingFace loader#52
suzukimain merged 2 commits intoupdate-v9from
copilot/sub-pr-49-another-one

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Dec 16, 2025

Address review feedback on #49 requesting consistent log levels across from_huggingface methods.

Changes

  • Changed logger.info to logger.warning for checkpoint_path logging in _load_pipeline_with_retries (line 1219)
  • Restores consistency with Civitai loaders at lines 1746, 1988, 2230 which all use logger.warning
# Before
logger.info(
    f"checkpoint_path: {hf_checkpoint_status.model_status.download_url}"
)

# After  
logger.warning(
    f"checkpoint_path: {hf_checkpoint_status.model_status.download_url}"
)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: suzukimain <131413573+suzukimain@users.noreply.github.com>
Copilot AI changed the title [WIP] Update model loading implementation based on review feedback Restore logger.warning for checkpoint_path in HuggingFace loader Dec 16, 2025
Copilot AI requested a review from suzukimain December 16, 2025 10:12
@suzukimain suzukimain marked this pull request as ready for review December 16, 2025 10:17
Copilot AI review requested due to automatic review settings December 16, 2025 10:17
@suzukimain suzukimain merged commit 918e968 into update-v9 Dec 16, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the log level from logger.info to logger.warning for checkpoint_path logging in the HuggingFace loader's _load_pipeline_with_retries function to ensure consistency with similar logging statements in the Civitai loaders.

  • Unified log level for checkpoint_path across all loader methods (HuggingFace and Civitai)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants