Extract duplicate retry logic from from_huggingface methods#51
Merged
suzukimain merged 4 commits intoupdate-v9from Dec 16, 2025
Merged
Extract duplicate retry logic from from_huggingface methods#51suzukimain merged 4 commits intoupdate-v9from
suzukimain merged 4 commits intoupdate-v9from
Conversation
- Created _load_pipeline_with_retry helper function to consolidate retry logic - Updated all three from_huggingface methods to use the shared helper - Reduced code duplication by ~93 lines - Maintained identical behavior across all three pipeline types Co-authored-by: suzukimain <131413573+suzukimain@users.noreply.github.com>
- Removed incorrect failed_count increment before warning - Adjusted warning message format to match original code - Ensures backward compatibility with existing behavior Co-authored-by: suzukimain <131413573+suzukimain@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on model loading enhancements
Extract duplicate retry logic from from_huggingface methods
Dec 16, 2025
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The retry logic for model loading was duplicated identically across three
from_huggingfacemethods inEasyPipelineForText2Image,EasyPipelineForImage2Image, andEasyPipelineForInpainting.Changes
Extracted
_load_pipeline_with_retryhelper function that encapsulates:Updated all three
from_huggingfacemethods to delegate to the helper, passing only:Impact
Reduces code by ~93 lines. Future changes to retry behavior now require updates in a single location.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.