Add ref parameter to checkout step and log event name in maintenance workflow#48
Add ref parameter to checkout step and log event name in maintenance workflow#48suzukimain merged 1 commit intomasterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a ref parameter to the checkout step and introduces logging for the event name in the maintenance workflow. The changes aim to improve visibility and ensure the correct branch is checked out during workflow execution.
- Adds explicit
refparameter to the checkout action - Introduces event name logging for better debugging visibility
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| with: | ||
| ref: ${{ github.ref }} | ||
|
|
There was a problem hiding this comment.
The ref parameter is redundant in this context. By default, actions/checkout@v4 already checks out the ref that triggered the workflow, which is exactly what github.ref contains. This is the default behavior, so explicitly specifying ref: ${{ github.ref }} provides no additional value and should be removed to keep the configuration clean and simple.
| with: | |
| ref: ${{ github.ref }} |
| python -m pip install --upgrade pip setuptools wheel | ||
| pip install -U torch --index-url https://download.pytorch.org/whl/cpu | ||
|
|
||
| echo "Event name: ${{ github.event_name }}" |
There was a problem hiding this comment.
The echo statement for logging the event name is placed within the "Install dependencies" step, making it appear as part of dependency installation rather than as a separate diagnostic log. This placement could be confusing. Consider moving this logging to a dedicated step or at least placing it before the dependency installation commands to make the workflow structure clearer.
Include a reference parameter in the checkout step to ensure the correct branch is checked out and log the event name for better visibility in the maintenance workflow.