fix: Add brackets to fix operator precedence when printing version#7
Merged
Conversation
Rust operator precedence has `+` higher than `<<`, so the expression was parsed as: ``` (buf[7] as u16) << (8 + buf[6] as u16) ``` causing: ``` alexk@alexk apftool-rs % ./target/debug/afptool-rs ~/Downloads/update.img . RKFW signature detected thread 'main' panicked at src/lib.rs:118:9: attempt to shift left with overflow note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ``` Add parentheses to force the shift before the addition and fix the output: ``` alexk@alexk apftool-rs % ./target/debug/afptool-rs ~/Downloads/update.img . RKFW signature detected version: 17.23.4112 family: RK3566 00000066-000401ec BOOT (size: 262535) 000401ed-09f169f0 embedded-update.img (size: 166553604) ``` Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Owner
|
Yes, this fix is correct. The original code:
The corrected version:
✅ This fix is correct and should be used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rust operator precedence has
+higher than<<, so the expression was parsed as:causing:
Add parentheses to force the shift before the addition and fix the output: