Skip to content

Add option for file permission#36

Merged
sushichop merged 1 commit intomainfrom
PR/add-option-permission
Jan 31, 2022
Merged

Add option for file permission#36
sushichop merged 1 commit intomainfrom
PR/add-option-permission

Conversation

@sushichop
Copy link
Copy Markdown
Owner

@sushichop sushichop commented Jan 31, 2022 •
edited
Loading

This PR refers #35.

I have added an option for file permission.
You can use this feature as follows.
Default permission is "640"

// e.g. 1
FileLogger("com.example.yourapp.file",
                   fileURL: "./yourlog.log",
                   filePermission: "600")
// e.g. 2
try! FileRotationLogger("com.example.yourapp.filerotation",
                                        fileURL: "./logs/foo.log",
                                        filePermission: "660")

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2022 •
edited
Loading

Codecov Report

Merging #36 (1a44416) into main (0d5f9f1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   95.83%   95.93%   +0.09%     
==========================================
  Files          11       11              
  Lines         408      418      +10     
==========================================
+ Hits          391      401      +10     
  Misses         17       17
Impacted Files Coverage Δ
Sources/Puppy/FileError.swift 100.00% <ø> (ø)
Sources/Puppy/FileLogger.swift 93.00% <100.00%> (+0.77%) ⬆️
Sources/Puppy/FileRotationLogger.swift 86.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5f9f1...1a44416. Read the comment docs.

@sushichop sushichop merged commit 90e2ab1 into main Jan 31, 2022
@sushichop sushichop mentioned this pull request Jan 31, 2022
Closed
@sushichop sushichop deleted the PR/add-option-permission branch January 31, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sushichop