ci: Add golangci-lint configuration and fix initial linting errors#32
Merged
supitsdu merged 3 commits intosupitsdu:mainfrom Jun 29, 2024
Merged
ci: Add golangci-lint configuration and fix initial linting errors#32supitsdu merged 3 commits intosupitsdu:mainfrom
supitsdu merged 3 commits intosupitsdu:mainfrom
Conversation
supitsdu
approved these changes
Jun 29, 2024
Owner
supitsdu
left a comment
There was a problem hiding this comment.
Seems good to me. Thanks for the contribution. Later I'll have to make a workflow to run the linter. I'll do some research and tests.
See: https://golangci-lint.run/welcome/install/#github-actions
See: https://github.com/golangci/golangci-lint-action
Contributor
Author
|
Yes, it can be added very easily. Have fun with golangci-lint and revive. It's a sane journey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request lays the groundwork for improving code quality by integrating
golangci-lint, a powerful Go linter. Here's what this PR accomplishes:Configuration Setup:
.golangci.ymlconfiguration file.Initial Code Cleanup:
golangci-lintin our existing codebase.Next Steps (Not Included in This PR):
golangci-lintinto our CI pipeline. This will enable automated linting on each pull request.golangci-lint, we can gradually enable more rules to enhance our code quality further.Review Checklist:
golangci-lintconfiguration is appropriate for our project.Fixes #20