[feature] add props "webViewStyle", support setting the style of WebView component.#56
Merged
supervons merged 1 commit intosupervons:masterfrom Jun 10, 2022
congshengwu:webview-style
Merged
[feature] add props "webViewStyle", support setting the style of WebView component.#56supervons merged 1 commit intosupervons:masterfrom congshengwu:webview-style
supervons merged 1 commit intosupervons:masterfrom
congshengwu:webview-style
Conversation
Owner
|
Thanks for your PR, test pass! I think it's a reasonable scenario. The next version will be released |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
It's a little change of this PR. Add a new props
webViewStyleforRNEChartsProto support customizing WebView style. Similar to the propswebViewSettings. If I set style via webViewSettings which will cover the default style from source code, I don't think it's a good choice.I meet a crash issue which is most likely from
react-native-webview, and settingopacity: 0.99of its style will resolve the crash issue. That's why I need this PR to change the style of WebView inside theRNEChartsPro.Besides, I think maybe users will have other needs to set the style of WebView in the future.
Test plan
Pass style like
opacity: 0.2inwebViewStyleCompatibility
Android and iOS.