Always remove the layer from layers array, even if session is null#9
Closed
vincentfretin wants to merge 1 commit intosupermedium:super-r147from
Closed
Always remove the layer from layers array, even if session is null#9vincentfretin wants to merge 1 commit intosupermedium:super-r147from
vincentfretin wants to merge 1 commit intosupermedium:super-r147from
Conversation
Member
|
Thanks so much. I leave this open. Working on r147 branch will be confusing and high chance for me to mess things up. I'll create a new branch and cherry pick this commit for a new super-three release. |
Author
|
I see you cherry-picked the commit in https://github.com/supermedium/three.js/commits/super-147-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes aframevr/aframe#5197
You can merge and squash it with the commit 84b2da1 if you
rebase -inext time you update threejs