Set anisotropy of ground and grid texture#95
Merged
dmarcos merged 1 commit intosupermedium:masterfrom Jun 17, 2023
Merged
Conversation
Member
|
Thanks so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anisotropy can make the texture sharper in the distance when viewed under a steep angle. With the environment we know the ground and grid textures will be viewed under such conditions, so the visual improvement is substantial. This is also mentioned in the following blog post by Oculus/Meta: Common Rendering Mistakes: How to Find Them and How to Fix Them
And in Project Flowerbed they seem to set it for all textures on models they load: SceneCreationSystem.js#L153
This PR simply sets anisotropy for the two textures used on the ground of the environment. Three.js takes care to not exceed the maximum capabilities of a device. So in case a device doesn't support anisotropy filtering, the setting won't have an effect.
Visual comparison (click to view in full size):