Use .applyColorCorrection on ground textures and dressing material color#84
Use .applyColorCorrection on ground textures and dressing material color#84dmarcos merged 3 commits intosupermedium:masterfrom
Conversation
719b81f to
f1b14be
Compare
|
Super thanks! |
|
From my understanding, those changes are needed for aframe 1.4.2 (r147) with colorManagement:true (and I have this combination in my project), but not needed for aframe master (r152), right? |
In aframe master it's no longer needed to call |
|
Seems that on master some more changes will be needed, investigating it |
|
Added a commit that fixes it for aframe-master. With the newer Three.js all Color instances were automatically converted, but the code does use instances of It's done in such a way that it works for both 1.4.2 and master. With |
|
Thank you very much! |
This PR introduces
.applyColorCorrectionfor ground textures and dressing material color to avoid washed out colors when enablingcolorManagement. See #83 for more details and caveats.Resolves #83