Merged
Conversation
scottpersinger
commented
Aug 13, 2025
| request_id=request_id, | ||
| ) | ||
| ) | ||
| # There's some logical issue where we have inserted 'thread_id' into the request_context, but |
Collaborator
Author
There was a problem hiding this comment.
@drbrady8800 this came up in some testing, where thread_context.thread_id inside a tool function was None when I expected a value. Seems like we had a case where the thread ID wouldn't get passed down into the agent loop properly.
drbrady8800
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduced some logging and dead prints.
Also fixes a bug, I think, where
thread_idis not communicated down to the ThreadContext properly.