Small UI improvements: detail toolbar, loading overlay, empty states#258
Merged
Small UI improvements: detail toolbar, loading overlay, empty states#258
Conversation
Match the detail-placeholder layout (large spinner, title, caption, 5-line animated tail) and replace the flat `state: .creating` / `statusLines:` bag with a `WorktreeLoadingInfo.Kind` enum carrying a `Progress` payload. Dead `.archiving` case dropped since archiving routes via the terminal.
Replace the plain branch label with a Label-based button carrying the GitHub owner avatar (same layout used in Settings), a rename popover for git worktrees, and a disabled folder-glyph label for folder repositories. `WorktreeToolbarState` now carries a `Kind` enum so "folder with a pull request" is unrepresentable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WorktreeToolbarStatenow carries aKindenum so "folder with a pull request" is unrepresentable.statusCommandcaption, 5-line animated tail).WorktreeLoadingInfoswitches from a flat bag of optionals to aKindenum with aProgresspayload; the dead.archivingcase is gone.EmptyStateView,EmptyTerminalPaneView) withDetailPlaceholderView'sVStack(spacing: 12)+VStack(spacing: 4)pattern, and normalize sidebar icon sizing + the Add button's Label wrapping.ToolbarItemGroup, hide the window-toolbar background, and center the detail placeholder text.Test plan
git worktree add …caption + tail lines animating in.make testpasses.