Conversation
Summary: - skip `tuist auth login` for fork-originated `pull_request` runs - keep Tuist OIDC authentication enabled for pushes and same-repo PRs Rationale: - fork PR workflows do not get `id-token: write`, so the shared setup action cannot request a GitHub OIDC token there - skipping the auth step in that context avoids failing CI before the actual job work starts Tests: - `make check` - `make build-app`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tuist auth loginwhen CI runs for fork-originatedpull_requesteventsWhy
Fork PR workflows do not receive GitHub OIDC request variables, so the shared
macOS setup action fails before the actual job starts. This keeps the shared
setup working in trusted contexts and avoids breaking fork PR validation.
Validation
make checkmake build-app