Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
open_urlactions for local filesystem paths directly in the app, so plain terminal paths can be opened immediately instead of only being stored in transient Ghostty state.ghosttyOpenURLRequestto normalize Ghostty URL payloads into either passthrough remote URLs or standardized local file URLs, covering plain absolute paths, relative paths, paths with spaces, and tilde-prefixed paths similar to Supaterm.~user/..., by relying onNSString(...).expandingTildeInPathinstead of concatenating onto the current user home path.~user/...correctly.Test plan
https://...link and verify it still opens in the browser instead of being treated as a local file path.~/...local path and verify it resolves against the current user home directory.~user/...local path and verify it resolves to that named user home directory rather than being appended to the current user home path.~user/..., save, reopen the setting, and verify the resolved path and example worktree path still point at the named user home.Closes #234