Fix Ghostty make targets for paths with spaces#210
Merged
Conversation
Keep Ghostty build outputs as real Make targets so incremental rebuilds still work when an output is deleted. Use repo-relative target and recipe paths instead of a stamp file, and remove the unused .ghostty-built ignore entry.
bdab4c3 to
e189b1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
makeworks from repo roots whose path contains spacesTest plan
make build-appfrom a path with spacesFrameworks/GhosttyKit.xcframework,Resources/ghostty, andResources/terminfo, then runmake build-appmake build-ghostty-xcframeworkagain and confirm it is a no-op when outputs are present