Fix multiline script editor in settings#202
Merged
sbertix merged 5 commits intosupabitapp:mainfrom Apr 1, 2026
Merged
Conversation
sbertix
requested changes
Apr 1, 2026
| PlainTextEditor( | ||
| text: text, | ||
| isMonospaced: true, | ||
| style: .field |
Collaborator
There was a problem hiding this comment.
I guess it would possibly need to be .plain to match the rest of the app? 🤔 with this we're getting a bordered white box
Contributor
Author
|
It's actually that PlainTextEditor is used in ContentView.swift. So nothing that specific. |
Collaborator
We'll get to it too in time 😅 since neither needs to auto-grow and all modifiers can be represented, I'd just go with |
sbertix
requested changes
Apr 1, 2026
Co-authored-by: Stefano Bertagno <stefano@bertagno.com>
Co-authored-by: Stefano Bertagno <stefano@bertagno.com>
sbertix
approved these changes
Apr 1, 2026
Collaborator
|
Thanks 🙇♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: pressing Enter in repository settings script fields selected the whole value instead of inserting a newline because the UI used a vertical TextField on macOS.
Fix: switch those script fields to the existing NSTextView-backed PlainTextEditor so Enter inserts a line break normally while keeping the multiline field behavior.