Skip to content

ci(ci): pin windows runner and migrate github app token to client-id#2406

Merged
mandarini merged 1 commit into
masterfrom
ci/update-action-syntax
May 28, 2026
Merged

ci(ci): pin windows runner and migrate github app token to client-id#2406
mandarini merged 1 commit into
masterfrom
ci/update-action-syntax

Conversation

@mandarini

@mandarini mandarini commented May 28, 2026

Copy link
Copy Markdown
Contributor

Address two GitHub Actions deprecation notices surfaced on recent runs, and document why the upcoming GitHub App installation token format change is a no-op for this repo.

  • Pin the Windows runner: windows-latest is being redirected to windows-2025-vs2026 on June 15, 2026. Pinning explicitly in ci-supabase-js.yml avoids a silent image flip on the redirect date.
  • Migrate actions/create-github-app-token from the deprecated app-id input to client-id across 9 call sites in 4 workflows (deprecate-version, dogfood, publish, revert-commit).
  • New secrets APP_CLIENT_ID and DOGFOOD_APP_CLIENT_ID must be added in repo settings before merge. They hold each GitHub App's Client ID (string like Iv23...), which is a different value than the numeric App ID. PRIVATE_KEY / DOGFOOD_APP_PRIVATE_KEY are unchanged. Old APP_ID / DOGFOOD_APP_ID can be removed after one green canary run.
  • Upcoming ghs_... installation token format (~520 chars): checked all workflows and scripts. No length assumptions or string slicing on tokens, so no code change is required.

@mandarini mandarini requested review from a team as code owners May 28, 2026 13:36
@mandarini mandarini self-assigned this May 28, 2026

@staaldraad staaldraad left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the CLIENT_ID's 🤞🏼

@mandarini mandarini merged commit e5cf295 into master May 28, 2026
22 checks passed
@mandarini mandarini deleted the ci/update-action-syntax branch May 28, 2026 14:09

Copy link
Copy Markdown
Contributor Author

thank youUuuuuu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants