ci(ci): pin windows runner and migrate github app token to client-id#2406
Merged
Conversation
staaldraad
approved these changes
May 28, 2026
staaldraad
left a comment
Member
There was a problem hiding this comment.
I've added the CLIENT_ID's 🤞🏼
Contributor
Author
|
thank youUuuuuu |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address two GitHub Actions deprecation notices surfaced on recent runs, and document why the upcoming GitHub App installation token format change is a no-op for this repo.
windows-latestis being redirected towindows-2025-vs2026on June 15, 2026. Pinning explicitly inci-supabase-js.ymlavoids a silent image flip on the redirect date.actions/create-github-app-tokenfrom the deprecatedapp-idinput toclient-idacross 9 call sites in 4 workflows (deprecate-version,dogfood,publish,revert-commit).APP_CLIENT_IDandDOGFOOD_APP_CLIENT_IDmust be added in repo settings before merge. They hold each GitHub App's Client ID (string likeIv23...), which is a different value than the numeric App ID.PRIVATE_KEY/DOGFOOD_APP_PRIVATE_KEYare unchanged. OldAPP_ID/DOGFOOD_APP_IDcan be removed after one green canary run.ghs_...installation token format (~520 chars): checked all workflows and scripts. No length assumptions or string slicing on tokens, so no code change is required.