fix(auth): preserve session when magic link is clicked twice #1996
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
removes the
removeSession()call ininitialize()when url based login fails, preserving valid sessions when users click a magic link more than onceproblem
when a user clicks a magic link twice, the second click fails because the token is already consumed. the old code called
removeSession()on this failure, which destroyed the valid session from the first click, logging the user out unexpectedly.solution
don't call
removeSession()on url login failure. a failed login attempt should never invalidate an existing valid session.the original comment claimed this matched
verifyOtp, signUp, signInWithbehavior, but none of those methods callremoveSession()on error.related
closes #1685