fix(postgrest): use post with return minimal for rpc head requests with object args #1994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandarini
requested changes
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Thanks for this fix @7ttp! Please add a test to prevent regression. Here's a suggested approach using mock fetch:
// In packages/core/postgrest-js/test/fetch-errors.test.ts or new file
test('rpc with head: true and object args uses POST with return=minimal', async () => {
const mockFetch = jest.fn().mockResolvedValue({
ok: true,
status: 200,
statusText: 'OK',
headers: new Headers(),
json: async () => null,
text: async () => '',
})
const postgrest = new PostgrestClient<Database>('https://example.com', {
fetch: mockFetch as any,
})
await postgrest.rpc('my_func', { obj_arg: { nested: 'value' } }, { head: true })
const [url, options] = mockFetch.mock.calls[0]
expect(options.method).toBe('POST')
expect(JSON.parse(options.body)).toEqual({ obj_arg: { nested: 'value' } })
expect(options.headers.get('Prefer')).toContain('return=minimal')
})Once added, this looks good to merge!
mandarini
approved these changes
Jan 7, 2026
mandarini
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes object args being serialized as
[object Object]when usingrpc()withhead: truewhen
head: trueis used with object type arguments, the client now uses POST withPrefer: return=minimalheader instead of HEAD, since HEAD requests cannot have a body and objects cannot be properly serialized to URL params.closes supabase/supabase#41641