fix(realtime): add generic overload for postgres_changes event type#1984
Merged
Conversation
Contributor
|
@7ttp thank you for this PR. Can you please add a test for the new functionality? It can go in ...
const event: '*' | 'INSERT' | 'UPDATE' | 'DELETE' = 'INSERT'
// This should compile without errors (previously required `as any`)
channel.on(
'postgres_changes',
{
event,
schema: 'public',
table: 'users',
},
...
)
...
expect(channel.bindings.postgres_changes.length).toBe(1)
... |
b3203b7 to
29c680b
Compare
Contributor
Author
|
@mandarini could u please have a look at this now! |
mandarini
approved these changes
Jan 22, 2026
Contributor
|
@7ttp can you please rebase your PR with latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a generic overload for
on()withpostgres_changesthat accepts any event type, enabling reusable subscription helpers with union types like'*' | 'INSERT' | 'UPDATE' | 'DELETE'.Fixes "No overload matches this call" error when passing generic event parameters to
channel.on('postgres_changes', ...).closes #1451