fix(postgrest): prevent shared state between query builder operations #1978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3422ca2 to
da87e08
Compare
mandarini
requested changes
Jan 5, 2026
Contributor
mandarini
left a comment
There was a problem hiding this comment.
Can we add a regression test? Something like:
it('should not share state between operations on same query builder', async () => {
const table = postgrest.from('users');
const q1 = table.select('*').eq('id', 1);
const q2 = table.select('*').eq('id', 2);
expect(q1.url.toString()).not.toContain('id=eq.2');
expect(q2.url.toString()).not.toContain('id=eq.1');
});1a7851d to
8d4ad19
Compare
Contributor
Author
|
Added test for shared state isolation between query builder operations. |
mandarini
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when reusing a
PostgrestQueryBuilderinstance returned by.from(),url search params and headers were being shared across multiple operations,
causing filters to accumulate unexpectedly.
this fix ensures each operation receives its own cloned state.
fixes #1640