fixes quotes in search result (using cmdk) crashes the application#18302
Merged
fsansalvadore merged 5 commits intosupabase:masterfrom Nov 7, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
@YugBhanushali is attempting to deploy a commit to the Supabase Team on Vercel. A member of the Team first needs to authorize it. |
fsansalvadore
approved these changes
Nov 7, 2023
Contributor
fsansalvadore
left a comment
There was a problem hiding this comment.
Awesome, thanks @YugBhanushali!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
If the search results contain quotes, then the app does not crash when the user hovers over the results, and during click on the result the user is redirected to the corresponding documents.
What is the current behavior?
Currently, when the user hovers over a search result containing quotes, it leads to an app crash.
before.pr.mov
What is the new behavior?
User is able to hover and is able to click on the search results containing quotes and gets redirected to corresponding docs.
after.pr.mov
Additional context
Fixes #18276