fix: use static list of project regions #4692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20786460683Details
💛 - Coveralls |
sweatybridge
approved these changes
Jan 7, 2026
Contributor
sweatybridge
left a comment
There was a problem hiding this comment.
Looks good! just did some minor refactoring
Contributor
|
I did more testing and found that it doesn't actually work. Reason is we need to parse the let me see if there's another alternative currently settling on a static list of regions to unblock |
Contributor
Author
|
🤦♂️ Yeah, I completely overlooked |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix #4689
What is the new behavior?
LoadProfile is called before awsRegions are loaded.
Additional context
regionvar is initialized at package scope in projects.go. As regions are scoped to profile now (#4596), at this point the current profile isn't loaded yet so theregion.Allowedis set to empty slice.LoadProfileis called insiderootCmd.PersistentPreRunEwhich runs after flag parsing and flag validation.Marking this as a draft for now to get early feedback from maintainers. Happy to adjust the approach if there's a preferred pattern here.