Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

chore: update workflow check-conventional-commits#962

Merged
kangmingtay merged 2 commits into
masterfrom
chore/update-workflows
Oct 14, 2024
Merged

chore: update workflow check-conventional-commits#962
kangmingtay merged 2 commits into
masterfrom
chore/update-workflows

Conversation

@staaldraad

Copy link
Copy Markdown
Member

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

Some github.event messages can break the workflow. Backticks get interpreted by the shell, this is a security risk and also breaks most Dependabot PRs.

What is the new behavior?

Updates the workflow to deal with special characters that might be interpreted by the shell

Additional context

Should fix https://github.com/supabase/auth-js/actions/runs/11035778554/job/30652617566

Updates the workflow to deal with the fact that ``` in the github.event
leading to code execution
@staaldraad staaldraad force-pushed the chore/update-workflows branch 2 times, most recently from 6bc8a8a to b72d213 Compare September 25, 2024 15:34
@staaldraad staaldraad requested a review from hf September 26, 2024 07:05
@staaldraad staaldraad force-pushed the chore/update-workflows branch from b72d213 to 5c6e517 Compare October 8, 2024 08:23
@kangmingtay kangmingtay merged commit ae73401 into master Oct 14, 2024
@kangmingtay kangmingtay deleted the chore/update-workflows branch October 14, 2024 03:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants