feat: correct implementation of partial block#699
Merged
Conversation
|
Thank you! |
Owner
Author
|
Just trying to validate on your project. |
Owner
Author
|
@hrydgard it should work now. I will look into another partial issue tomorrow and cut a release soon. |
|
Finally got around to updating. It works fine, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #698 #696
This patch finally reimplements partial's block context correctly. The key is to remove all previous blocks and use a separated one for partial.
It corrects behavior of partial parameter, hash and merge_json:
thisas base_valueotherwise, use base value directly
When partial is rendered, reset blocks.
Tests added.