Skip to content

fix(#666): Add builder for non-exhaustive structs#688

Merged
sunng87 merged 3 commits into
sunng87:masterfrom
hadizamani021:feat/add-builder-for-non-exhaustive-structs
Dec 25, 2024
Merged

fix(#666): Add builder for non-exhaustive structs#688
sunng87 merged 3 commits into
sunng87:masterfrom
hadizamani021:feat/add-builder-for-non-exhaustive-structs

Conversation

@hadizamani021

@hadizamani021 hadizamani021 commented Dec 21, 2024

Copy link
Copy Markdown
Contributor

issue (#666)

@hadizamani021 hadizamani021 changed the title Add builder for non-exhaustive structs 666 Add builder for non-exhaustive structs #666 Dec 21, 2024
@hadizamani021 hadizamani021 changed the title Add builder for non-exhaustive structs #666 Fix(#666): Add builder for non-exhaustive structs Dec 21, 2024
@hadizamani021 hadizamani021 changed the title Fix(#666): Add builder for non-exhaustive structs Fix(666): Add builder for non-exhaustive structs Dec 21, 2024
@hadizamani021 hadizamani021 changed the title Fix(666): Add builder for non-exhaustive structs fix(#666): Add builder for non-exhaustive structs Dec 21, 2024
@sunng87

sunng87 commented Dec 23, 2024

Copy link
Copy Markdown
Owner

@hadizamani021 Thank you! You can use derive_builder crate to generate builders for this case.

@coveralls

coveralls commented Dec 23, 2024

Copy link
Copy Markdown

Coverage Status

coverage: 82.062% (+0.04%) from 82.024%
when pulling 111cb9f on hadizamani021:feat/add-builder-for-non-exhaustive-structs
into 190bc3b on sunng87:master.

@sunng87

sunng87 commented Dec 24, 2024

Copy link
Copy Markdown
Owner

LGTM. Is there any other struct to add builder?

@hadizamani021

Copy link
Copy Markdown
Contributor Author

@sunng87 Thank you sunng, I added for all non_exhaustive structs.

@sunng87

sunng87 commented Dec 25, 2024

Copy link
Copy Markdown
Owner

@hadizamani021 Thank you!

@sunng87 sunng87 merged commit 891426f into sunng87:master Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants