Eliminate RenderContextInner#662
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I realized that there's one last thing I think we could consider before v6.0.
Now that we no longer clone the
RenderContextwe could get rid of the slightly hackyRenderContextInnerand the whole writing through an
Rcidiom associated with it.I know I initially said that I don't expect any more breaking changes,
but I missed that this narrows the lifetime contract on the public
RenderContexttype.This shouldn't really affect anybody (
'reg: 'rcis basically assumed everwhere already),but as a matter of technicality might be semver incompatible.
This should now really be the last breaking change in the indent patch series though :).