apply clippy fixes#659
Merged
Merged
Conversation
Owner
|
Thank you! Because our tests are not covered by github check. Could you please also add |
sunng87
approved these changes
Jul 14, 2024
sunng87
left a comment
Owner
There was a problem hiding this comment.
I will merge this and add github check myself. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes all 86 warnings that clippy currently generates on this project.
Most of these are in test code and don't really matter.
I still believe this is worth it because it makes the use of clippy viable when working on this project.
Currently you are quite likely to miss any issues you introduce because there's already so many warnings.
If you disagree, feel free to close this.
This was partially autogenerated using
cargo clippy --fix, but manually reviewed & cleaned up.Should hopfully be very easy to review, as nothing really happens.