impl From<RenderError> for RenderErrorReason#644
Merged
sunng87 merged 1 commit intoJun 14, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just allows one to get the
RenderErrorReasonout of aRenderErrorby value.The current
reason()function only gives a reference, and thereasonmember is notpub(presumably for good reason).My usecase for this is that I am using
render_to_writewith known, good data.So the only possible error is an
std::io::Errorfrom the underlying writer, so I want to return that.Unfortunately,
std::io::Errorisn'tCloneso I can't get it out of the&RenderErrorReasonthat I'm currently getting.I figured this was simple enough to not require a huge discussion in an issue first, but I'll gladly implement a different solution for this usecase if this conversion function is not acceptable for some reason.
Cheers and thank you for the awesome library.