Skip to content

Re-export JsonTruthy#610

Merged
sunng87 merged 1 commit into
sunng87:masterfrom
Dosenpfand:reexport-json-truthy
Sep 28, 2023
Merged

Re-export JsonTruthy#610
sunng87 merged 1 commit into
sunng87:masterfrom
Dosenpfand:reexport-json-truthy

Conversation

@Dosenpfand

Copy link
Copy Markdown

Or is there a specific reason why this is not done?

@sunng87

sunng87 commented Sep 27, 2023

Copy link
Copy Markdown
Owner

@Dosenpfand do you have a use-case for JsonTruthy? when implementing your own helper?

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 81.112%. remained the same when pulling 818855e on Dosenpfand:reexport-json-truthy into 825baea on sunng87:master.

@sunng87 sunng87 merged commit ea93c15 into sunng87:master Sep 28, 2023
@Dosenpfand

Dosenpfand commented Oct 22, 2023

Copy link
Copy Markdown
Author

@sunng87, thanks for merging this!

@Dosenpfand do you have a use-case for JsonTruthy? when implementing your own helper?

Yes, exactly. I am using dotter which uses handlebars-rust with strict mode enabled.

Even with strict mode enabled it would still useful i my opinion, to have a non-strict version of the and and or helpers available. Would you accept a PR for that? Otherwise, I would try to get it merged into dotter itself.

@Dosenpfand Dosenpfand deleted the reexport-json-truthy branch October 22, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants