Skip to content

Render arrays without trailing commas#588

Merged
sunng87 merged 1 commit into
sunng87:masterfrom
aromeronavia:alberto/render-arrays-without-trailing-commas
Jun 14, 2023
Merged

Render arrays without trailing commas#588
sunng87 merged 1 commit into
sunng87:masterfrom
aromeronavia:alberto/render-arrays-without-trailing-commas

Conversation

@aromeronavia

Copy link
Copy Markdown

Problem

Arrays are being rendered with trailing commas
Related to #587

Solution

Verify when rendering an array that last element being rendered does not include a comma and space

Added tests ✅

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 80.81% (+0.09%) from 80.717% when pulling 7d78793 on aromeronavia:alberto/render-arrays-without-trailing-commas into 23ca8d7 on sunng87:master.

@sunng87

sunng87 commented Jun 14, 2023

Copy link
Copy Markdown
Owner

Nice! Thank you very much!

@sunng87 sunng87 merged commit 5dc55a6 into sunng87:master Jun 14, 2023
@aromeronavia aromeronavia deleted the alberto/render-arrays-without-trailing-commas branch June 16, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants