Skip to content

Able to get the missing variable path from error #546

Merged
sunng87 merged 6 commits into
sunng87:masterfrom
linw1995:master
Nov 21, 2022
Merged

Able to get the missing variable path from error #546
sunng87 merged 6 commits into
sunng87:masterfrom
linw1995:master

Conversation

@linw1995

Copy link
Copy Markdown
Contributor

This allows developers to get the missing variable path from the error and produce a customized hint message to the frontend users.

Comment thread src/error.rs Outdated

@sunng87 sunng87 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also please check format and lint errors. Thanks!

Comment thread src/error.rs Outdated
@coveralls

coveralls commented Nov 21, 2022

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.2%) to 79.988% when pulling 832679d on linw1995:master into 80687a7 on sunng87:master.

@sunng87

sunng87 commented Nov 21, 2022

Copy link
Copy Markdown
Owner

LGTM. @linw1995 Thanks for your patient!

@sunng87 sunng87 merged commit b70f773 into sunng87:master Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants