Refactor dir_source to be more ideomatic#500
Merged
Conversation
Owner
|
@Fallen4Eyes Thank you for the patch! There is a test case failure, please check. |
sunng87
reviewed
Apr 7, 2022
sunng87
reviewed
Apr 7, 2022
Author
|
I made changes in order to preserve the functionality of the old code as I misunderstood it's functionality. |
sunng87
approved these changes
Apr 11, 2022
Owner
|
@Fallen4Eyes Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was originally for allowing extensions to not be prefixed by a dot which lead to a general refactor of dir_source.
The main change is that tpl_extension in register_templates_directory doesn't need a dot in the front and non-utf8 file names will not be registered unlike before where mangled strings will be registered.