Skip to content

[EuiDataGrid] Adjust footer row styles and make it sticky#1

Merged
sulemanof merged 4 commits intosulemanof:data_grid/footer_rowfrom
andreadelrio:footer_row_styles
Sep 16, 2020
Merged

[EuiDataGrid] Adjust footer row styles and make it sticky#1
sulemanof merged 4 commits intosulemanof:data_grid/footer_rowfrom
andreadelrio:footer_row_styles

Conversation

@andreadelrio
Copy link
Copy Markdown

@andreadelrio andreadelrio commented Sep 1, 2020 •
edited
Loading

Summary

The behaviour I'm proposing for the styling of the footer row is as follows:

a) striped: it's shaded following the odd/even styling of the rest of the datagrid. Needs to be used with stripes={true}.
b) overline: gets a thick black line above.
c) shaded: always gets a gray background.

modes_e

I also made the footer sticky. See below:
aaaa

Checklist

  • This was checked in mobile
  • This was checked in dark mode
  • Any props added have proper autodocs
  • Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
  • Jest tests were updated or added to match the most common scenarios
  • This was checked against keyboard-only and screenreader scenarios

@andreadelrio andreadelrio mentioned this pull request Sep 1, 2020
Merged
10 tasks
andreadelrio
andreadelrio commented Sep 1, 2020
View reviewed changes
@sulemanof
Copy link
Copy Markdown
Owner

sulemanof commented Sep 15, 2020

Introducing the striped option looks good to me!

I have the only concern about the sticky footer. Maybe it's better to make this optional?
E.x.:

gridStyle={{
  // ...
  stickyFooter: true,
}}

@andreadelrio
Copy link
Copy Markdown
Author

andreadelrio commented Sep 16, 2020

Introducing the striped option looks good to me!

I have the only concern about the sticky footer. Maybe it's better to make this optional?
E.x.:

gridStyle={{
  // ...
  stickyFooter: true,
}}

@sulemanof made the sticky footer optional! can you take a look again please?

@sulemanof
Copy link
Copy Markdown
Owner

sulemanof commented Sep 16, 2020

@sulemanof made the sticky footer optional! can you take a look again please?

Cool 👍
LGTM!

Do we need someone else review here or I could simply merge it ?

@andreadelrio
Copy link
Copy Markdown
Author

andreadelrio commented Sep 16, 2020 via email •
edited
Loading

@sulemanof sulemanof merged commit 5b52f23 into sulemanof:data_grid/footer_row Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andreadelrio @sulemanof