tests/commands/status.test.ts (1)

534-551: Hoist __test__ import and replace require() with a top-level ESM import.

Both test bodies independently call require() to obtain createProgressBar, which is inconsistent with the file's ES-module style and duplicates the extraction. mock.module only intercepts ../../src/session/index.js, so a top-level import of __test__ from status.js is safe and idiomatic.

♻️ Proposed refactor

Add to the existing status.js imports at the top of the file (alongside line 7):

-import { printStatusHelp } from '../../src/commands/status.js';
+import { printStatusHelp, __test__ } from '../../src/commands/status.js';

Then update the describe block:

 describe('progress bar rendering', () => {
+  const { createProgressBar } = __test__ as { createProgressBar: (percent: number, width: number) => string };
+
   test('clamps invalid percent values to avoid RangeError', () => {
-    const { __test__ } = require('../../src/commands/status.js');
-    const { createProgressBar } = __test__ as { createProgressBar: (percent: number, width: number) => string };
-
     expect(createProgressBar(-10, 10)).toBe('[░░░░░░░░░░]');
     expect(createProgressBar(150, 10)).toBe('[██████████]');
     expect(createProgressBar(Number.NaN, 10)).toBe('[░░░░░░░░░░]');
   });

   test('handles non-finite width safely', () => {
-    const { __test__ } = require('../../src/commands/status.js');
-    const { createProgressBar } = __test__ as { createProgressBar: (percent: number, width: number) => string };
-
     expect(createProgressBar(50, Number.NaN)).toBe('[]');
     expect(createProgressBar(50, Number.POSITIVE_INFINITY)).toBe('[]');
   });
 });

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/commands/status.test.ts` around lines 534 - 551, Hoist the test-only
export import by adding a top-level ESM import for __test__ from the status
module and remove the inline require() calls inside the tests; then extract
createProgressBar from __test__ once (e.g. const { createProgressBar } =
__test__) near the other imports and update both tests to use that single
binding. Ensure this change does not interfere with the existing mock.module
interception of session/index.js (the import is safe because mock.module targets
../../src/session/index.js), and run the tests to verify behavior for
createProgressBar with invalid percent and non-finite width.

src/commands/status.ts (1)

419-428: Correctness looks good; normalizedPercent branch can be simplified.

The three-way isFinite / === Infinity / else guard is correct, but it is equivalent to a single expression that leverages Math.max/Math.min behaviour on ±Infinity natively, which is simpler and removes the percent === Infinity special-case entirely:

♻️ Suggested simplification

-  const normalizedPercent = Number.isFinite(percent)
-    ? Math.min(100, Math.max(0, percent))
-    : percent === Infinity
-      ? 100
-      : 0;
+  const normalizedPercent = Number.isNaN(percent)
+    ? 0
+    : Math.min(100, Math.max(0, percent));

Math.max(0, -Infinity) === 0 and Math.min(100, Infinity) === 100, so the two previously explicit branches are handled implicitly.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/commands/status.ts` around lines 419 - 428, Replace the three-way
normalizedPercent branch in createProgressBar with a simpler expression that
removes the explicit Infinity check: compute normalizedPercent as
Number.isFinite(percent) ? Math.min(100, Math.max(0, percent)) : 0 so
NaN/non-finite values yield 0 while ±Infinity are clamped by Math.min/Math.max;
update the normalizedPercent assignment accordingly.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro