Allow runtime updates to autoCommit setting via TUI#333
Merged
Conversation
The autoCommit config option was ignored at runtime because settings changes from the TUI were saved to disk and updated in React state, but never propagated to the ExecutionEngine instance. Add setAutoCommit() to the engine and call it from handleSaveSettings. https://claude.ai/code/session_012YFAFfSsnbpganDrHnxR2N
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
==========================================
+ Coverage 45.95% 45.97% +0.01%
==========================================
Files 100 100
Lines 32252 32263 +11
==========================================
+ Hits 14823 14833 +10
- Misses 17429 17430 +1
🚀 New features to boost your workflow:
|
- Add setAutoCommit tests to engine test suite (toggle, preserve, default) - Extract propagateSettingsToEngine as testable helper in run.tsx - Add tests for propagateSettingsToEngine (true/false/undefined/null engine) - Engine coverage: 75.58% funcs, 69.40% lines https://claude.ai/code/session_012YFAFfSsnbpganDrHnxR2N
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
WalkthroughA new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change enables the autoCommit setting to be updated at runtime through the TUI settings view without requiring an application restart.
Key Changes
setAutoCommit()method toExecutionEngineclass to allow runtime updates to the autoCommit configurationhandleSaveSettings()in the run command to propagate autoCommit changes from the settings view to the engine instanceImplementation Details
The
setAutoCommit()method provides a simple interface to update the engine's internal config state. When settings are saved through the TUI, the handler now checks if the autoCommit value has changed and syncs it to the running engine instance, allowing users to toggle auto-commit behavior without restarting the application.https://claude.ai/code/session_012YFAFfSsnbpganDrHnxR2N
Summary by CodeRabbit
Release Notes
New Features
Tests